Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete document #1359

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Remove obsolete document #1359

merged 2 commits into from
Oct 18, 2024

Conversation

MichaelTimbert
Copy link

@MichaelTimbert MichaelTimbert commented Jun 10, 2024 •
edited by tgreenx
Loading

Purpose

This PR removes an obsolete document, docs/Translation-translators.md.

Context

Fixes #1358

How to test this PR

N/A.

@MichaelTimbert MichaelTimbert linked an issue Jun 10, 2024 that may be closed by this pull request
Broken link in documentation for translators #1358
Open
@tgreenx tgreenx added the A-Documentation Area: Documentation only. label Jun 12, 2024
@tgreenx tgreenx modified the milestones: v2024.1, v2024.2 Jun 12, 2024
@tgreenx
Copy link
Contributor

tgreenx commented Jun 12, 2024 •
edited
Loading

It seems that this document is not used in any Zonemaster component anymore. Instead of updating it, we can probably remove it.

$ ack "Translation-translators" ../
../zonemaster-engine/MANIFEST
4:docs/Translation-translators.md

@matsduf
Copy link
Contributor

matsduf commented Jun 12, 2024

Fine to remove.

@tgreenx tgreenx changed the title Link correction in docs Remove obsolete document Aug 20, 2024
@matsduf
Copy link
Contributor

matsduf commented Oct 11, 2024

@MichaelTimbert, please merge.

@MichaelTimbert MichaelTimbert merged commit 20788a7 into zonemaster:develop Oct 18, 2024
3 checks passed
@matsduf matsduf added the V-Patch Versioning: The change gives an update of patch in version. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-vanderwal marc-vanderwal marc-vanderwal approved these changes

@tgreenx tgreenx tgreenx approved these changes

@matsduf matsduf matsduf approved these changes

@mattias-p mattias-p Awaiting requested review from mattias-p

Assignees
No one assigned
Labels
A-Documentation Area: Documentation only. V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Milestone
v2024.2
Development

Successfully merging this pull request may close these issues.

Broken link in documentation for translators
4 participants
@MichaelTimbert @tgreenx @matsduf @marc-vanderwal