Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish CDS/CDNSKEY implementation #114

Closed
vlevigneron opened this issue May 10, 2021 · 2 comments · Fixed by #199
Closed

Finish CDS/CDNSKEY implementation #114

vlevigneron opened this issue May 10, 2021 · 2 comments · Fixed by #199
Assignees
Labels
S-PRforIssue Status: There is a PR that is meant to resolve the issue T-Feature Type: New feature in software or test case description
Milestone

Comments

@vlevigneron
Copy link
Contributor

  • Specific methods for CDS/CDNSKEY ressource records need to be implemented.
@ghost
Copy link

ghost commented Oct 6, 2022

Since the CDS (resp CDNSKEY) resource record format is identical to the DS record (resp DNSKEY record), we could make the Zonemaster::LDNS::RR::CDS (resp Zonemaster::LDNS::RR::CDNSKEY) a subclass of Zonemaster::LDNS::RR::DS (resp Zonemaster::LDNS::RR::DNSKEY).

@matsduf matsduf assigned ghost Oct 6, 2022
@matsduf matsduf modified the milestones: v2022.2, v2023.1 Dec 20, 2022
@matsduf matsduf modified the milestones: v2023.1, v2023.2 Jun 26, 2023
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Mar 19, 2024
@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
@tgreenx tgreenx added the T-Feature Type: New feature in software or test case description label Aug 19, 2024
@tgreenx tgreenx self-assigned this Aug 20, 2024
@tgreenx tgreenx linked a pull request Aug 20, 2024 that will close this issue
@tgreenx tgreenx added the S-PRforIssue Status: There is a PR that is meant to resolve the issue label Aug 20, 2024
@tgreenx
Copy link
Contributor

tgreenx commented Sep 12, 2024

Solved by #199.

Note that for some methods to work properly for these types of records, an update in LDNS will be required (version 1.8.5 as it appears). See NLnetLabs/ldns#246, NLnetLabs/ldns#247, NLnetLabs/ldns#248.

@tgreenx tgreenx closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-PRforIssue Status: There is a PR that is meant to resolve the issue T-Feature Type: New feature in software or test case description
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants