Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate case randomization feature #206

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Deprecate case randomization feature #206

merged 2 commits into from
Sep 5, 2024

Commits on Sep 2, 2024

  1. Deprecate case randomization feature 

    This feature has always been experimental and seems to have been
implemented a long time ago to test Zonemaster::LDNS internals. However,
there are better ways to ensure that.

This commit introduces deprecation warnings in three places:

 * in the documentation;
 * when executing Makefile.PL;
 * and during compilation of the C and XS code.

Hopefully, having the same warning in three different places will be
enough to alert end users.
    @marc-vanderwal
    marc-vanderwal committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    754ee8f View commit details
    Browse the repository at this point in the history

  2. Ensure unit tests still work with -DRANDOMIZE 

    Case in point (heh) of how little use the experimental case
randomization feature had: one unit tests broke without anyone noticing
it.

We can reverse this patch later when the feature is actually removed.
    @marc-vanderwal
    marc-vanderwal committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c11f083 View commit details
    Browse the repository at this point in the history