[DO NOT MERGE YET] Remove feature "randomized capitalization" #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature has always been experimental and seems to have been implemented a long time ago to test Zonemaster::LDNS internals. However, there are better ways to ensure that. This commit introduces deprecation warnings in three places: * in the documentation; * when executing Makefile.PL; * and during compilation of the C and XS code. Hopefully, having the same warning in three different places will be enough to alert end users.
Case in point (heh) of how little use the experimental case randomization feature had: one unit tests broke without anyone noticing it. We can reverse this patch later when the feature is actually removed.
No longer document the --randomize command-line argument to Makefile.PL, which is about to be removed.
Remove the possibility to define RANDOMIZE in CFLAGS by removing --randomize as a valid CLI argument.
Remove the deprecated feature entirely.
Remove a case-insensitive comparison that was done in t/rr.t in order to make unit tests pass on installations where the now removed case randomization feature was enabled. Previously, this equality comparison was done case-sensitively, which only worked when this feature was disabled. With this change, we can now be almost certain that we don’t do any case alterations anymore.
tgreenx
added
the
V-Minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this PR yet. After #206 is merged and v2024.2 is released, the branch corresponding to this PR is to be rebased on develop. Only then can it be merged.
Purpose
This PR removes an experimental and previously deprecated “randomized capitalization” feature from Zonemaster-LDNS.
Context
See #160 for the issue and discussion, and #206 for the initial deprecation warnings.
Changes
Remove the “randomized capitalization” feature from Zonemaster-LDNS. Update the documentation accordingly.
How to test this PR
In the root of the source tree of Zonemaster::LDNS, run cpanm -v --configure-args="--random" .
Among the roughly 30 first lines of output, expect this output (the version number of
Zonemaster-LDNSmay vary):Also, expect unit tests (which have been updated) to pass.