Skip to content

Commit

Permalink
Disable separateMajorMinor for pulldown-cmark dependency group
Browse files Browse the repository at this point in the history
Finally figured it out, this was the issue that was preventing renovate
from grouping pulldown-cmark and pulldown-cmark-to-cmark together in a
single PR.

See code comment for a more detailed description of why this is needed.
  • Loading branch information
zoni committed Aug 24, 2024
1 parent 5bede0a commit 2bee084
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,15 @@
// lockstep in case of breaking changes, so it's best to group them
// together.
"matchPackageNames": ["pulldown-cmark*"],
"groupName": "pulldown-cmark (grouped)"
// pulldown-cmark is currently on a 0.x release series while
// pulldown-cmark-to-cmark tends to bump the major version
// component whenever pulldown-cmark creates a new release (which
// increments the minor component). Renovate by default creates
// separate PRs for major and minor bumps which fails to match up
// with the grouping. Disabling this behavior ensures that both
// packages are always updated together in a single PR.
"separateMajorMinor": false,
"groupName": "pulldown-cmark (group)"
},
],
ignorePaths: [
Expand Down

0 comments on commit 2bee084

Please sign in to comment.