Skip to content

Commit

Permalink
Give release binaries file extensions
Browse files Browse the repository at this point in the history
This may make it more clear to users that these are precompiled, binary
files. This is especially relevant on Windows, where the convention is
that executable files have a .exe` extension, as seen in #49.
  • Loading branch information
zoni committed Jan 2, 2022
1 parent 84308c9 commit 67cd5ac
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
with:
upload_url: ${{ needs.create-release.outputs.upload_url }}
asset_path: target/release/obsidian-export
asset_name: obsidian-export_Linux-x86_64
asset_name: obsidian-export_Linux-x86_64.bin
asset_content_type: application/octet-stream

build-windows:
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
with:
upload_url: ${{ needs.create-release.outputs.upload_url }}
asset_path: target/release/obsidian-export.exe
asset_name: obsidian-export_Windows-x64_64
asset_name: obsidian-export_Windows-x64_64.exe
asset_content_type: application/octet-stream

build-macos:
Expand Down Expand Up @@ -121,5 +121,5 @@ jobs:
with:
upload_url: ${{ needs.create-release.outputs.upload_url }}
asset_path: target/release/obsidian-export
asset_name: obsidian-export_MacOS-x86_64
asset_name: obsidian-export_MacOS-x86_64.bin
asset_content_type: application/octet-stream

0 comments on commit 67cd5ac

Please sign in to comment.