Feat/text input #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hong-been
reviewed
Apr 24, 2022
| onFocus={handleFocus} | ||
| css={css} | ||
| /> | ||
| <div css={{position: "absolute", right: 0, bottom: 6}}> |
There was a problem hiding this comment.
오른쪽 버튼을 어떻게 스타일하실지 궁금했는데👍🏻👍🏻
근데 clear Icon을 감싸는 엘리먼트로 span대신 button은 어떨까요?
Hong-been
reviewed
Apr 24, 2022
components/textInput/textInput.tsx
Outdated
|
|
||
| const [localValue, setLocalValue] = useState("") | ||
|
|
||
| const inputRef = useRef<HTMLInputElement>(null) |
There was a problem hiding this comment.
지금은 inputRef를 input에 걸어두기만 하고 사용안하는거같은데, 나중에 언제필요한건가요?
|
컴포넌트이름이 파스칼로 안바뀌네요 😭 |
|
한번 머지하고 확인해보려고 ㅠ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add TextInput, TextInputPassword
Key Changes
Screenshots
Checklist
lint-fixts-check