Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/redux #9

Merged
merged 16 commits into from
May 1, 2022
Merged

Feat/redux #9

merged 16 commits into from
May 1, 2022

Conversation

hotbreakb
Copy link
Collaborator

Summary

  • redux-toolkit 사용
  • user state 추가

Key Changes

  • redux-toolkit을 사용하여 칭필보다 코드양이 줄었습니다.

Notes

  • 툴킷에 대해 전반적으로 이해하기 위해 개인 레포에서 작업하고 있습니다. basic-redux
  • 지금은 어떤 state를 만들어야 할지 잘 몰라서 컴포넌트 구현하면서 필요한 걸 하나씩 추가하겠습니다.

Checklist

  • test
  • lint-fix
  • ts-check

@hotbreakb hotbreakb requested a review from Hong-been April 28, 2022 04:15
Copy link
Collaborator

@Hong-been Hong-been left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨어요 👍🏻

@Hong-been
Copy link
Collaborator

Hong-been commented Apr 29, 2022

은지님 제가해봤을때 makeStore 부분을 이렇게 바꾸면 잘 작동하는거같은데, 혹시 어떤 문제가있을지 한번 봐주시겠어요?

export const makeStore = () => {
  const sagaMiddleware = createSagaMiddleware();
  const store = configureStore({
    reducer: rootReducer, 
    devTools: process.env.NODE_ENV !== "production",
    middleware: [sagaMiddleware, logger],
  });
  sagaMiddleware.run(rootSaga);
  return store
}

@hotbreakb hotbreakb merged commit d9eafc6 into develop May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants