Move all supported package metadata into pyproject.toml#86
Conversation
|
Side note: While experimenting I found that it's possible to declare the successful build of an extension module as optional, which lets a PyPy build proceed instead of failing immediately. But then the tests fail:
|
mauritsvanrees
left a comment
There was a problem hiding this comment.
LGTM. One setting could be removed, see inline suggestion. But it works as is when I try it locally.
One thing I don't like, is that this no longer adds the CHANGES.rst to the long_description. But it seems you cannot specify multiple files as source for project.readme. I tried, but ran into validation errors. I see that poetry supports this with an own setting. But I don't want to use poetry.
At least this is compensated by having a link to the changelog, so I guess we have to live with it. A lot of projects do this.
|
For this package with C-extensions it may be hard or impossible to completely get rid of So a small reminder of current buildout status when removing
|
Co-authored-by: Maurits van Rees <maurits@vanrees.org>
I'm guessing a lot of projects do this because they don't have a choice... Not being able to concatenate the change log into the description is annoying, I know.
Yes, we're not there yet, but this is a good first step. I think there's a lot of value in being able to parse and, if necessary, manipulate those values that only existed in setup.py before. |
|
@mauritsvanrees Speaking of zc.buildout 5, is there any holdup I can help with? No, rush, just wondering. |
|
@dataflake I like the approach to get all the config back into one file and one which is not code to be run at install time. Did you do the conversion |
|
@icemac I did it by hand. But once you have done a few it's more like copy/paste from previous packages and just changing details. |
@icemac Did you get a chance to test zc.buildout 5 on your projects yet? |
|
@mauritsvanrees I am running |
|
I have released |
|
Check out zopefoundation/Zope#1272 and the test failures. Looks like the Building and running the simpler |
This is a test for moving all project metadata that is fully supported from
setup.pyintopyproject.tomland clean up some small configuration items. Feedback highly welcome. This is like a blueprint for all ZF packages.Metadata for extension modules has not moved because...
ext-moduleskeyword is still experimental and likely to change.gcc fails to locate the header files when building binary wheels(binary wheels build correctly when adding an explicitinclude-dirs = ["src"]setup.pyI have also tried to clear up the author versus maintainer relationship by leaving author as "Zope Foundation and contributors" while adding "Plone Foundation and contributors" as maintainer. The Zope Foundation has not existed for many years now.