Enable history page for OFS.Image.File #396
Conversation
|
I remembered I also had this old patch. I understand history support is removed from master ( #346 ), but maybe this sill makes sense for 2.13 branch. If not, then don't hesitate to close this pull request. There's the same problem that tests are broken for 2.13 because of zc.recipe.egg version conflict. and there's no fix in this branch. Tests for this branch plus an extra commit to fix version conflicts are OK |
|
@perrinjerome Thank you for your pull request. Please rebase it to the current version of the 2.13 branch as I fixed TravisCI there in #393. Additionally please sign a Zope Committer Agreement, see https://github.com/zopefoundation/developer_docs/blob/master/source/Zope_Foundation_Committer_Agreement-20181008.pdf |
Use the standard history page, enabled using the same condition than the one that enables the text area on edit (ie. the file must be text or javascript and reasonably sized)
perrinjerome
force-pushed
the
feat/history_tab_for_ofs_file-2.13
branch
from
efb4cd3 to
2bdbfc3
Compare
|
Thanks I rebased. I remember now why I did not submit 4 years ago :) I'm trying to do this contributor agreement this time. |
|
Thanks, I just submitted a signed contributor agreement. |
perrinjerome
requested review from
aclark4life,
icemac and
leorochael
and removed request for
aclark4life
| self.file.manage_historyCompare( | ||
| self.file, | ||
| self.app.b, | ||
| self.app.REQUEST) |
There was a problem hiding this comment.
The test should assert something in the return value of the method.
There was a problem hiding this comment.
The return value of this method is the full html page. The diff is presented in an HTML table:
<table border=1>
<tr>
<td><pre>
-
+
</pre></td>
<td><pre>
content_of_a
content_of_b
</pre></td>
</tr>
</table>... which makes it not so easy to test.
I added simple assertions that the two versions of the content are present in the page.
add some assertions on the html returned by manage_historyCompare
|
Thanks for feedback @icemac ! I extended a bit the test and added a ChangeLog entry. |
|
Thanks for feedback,I'm merging this ! |
|
This change was only on 2.13 and not on Zope 5, I pushed a slightly updated version as #1245 |
Use the standard history page, enabled using the same condition than the one
that enables the text area on edit (ie. the file must be text or javascript and
reasonably sized)