Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with size calculation #915

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Resolve issue with size calculation #915

merged 3 commits into from
Nov 19, 2024

Conversation

DevonianTeuchter
Copy link
Collaborator

@DevonianTeuchter DevonianTeuchter commented Nov 19, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Content Update

Category

  • zopen build framework
  • zopen package manager
  • Documentation
  • CI/CD
  • Tools

Description

The logic to calculate free space fails completely if there is less than around 1Gb of space on the file system and will be off in other cases.

Related Issues

[optional] Are there any post-deployment tasks or follow-up actions required?

Copy link
Collaborator

@IgorTodorovskiIBM IgorTodorovskiIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should def add a test for this

@IgorTodorovskiIBM IgorTodorovskiIBM merged commit e5cae69 into main Nov 19, 2024
1 check failed
@IgorTodorovskiIBM IgorTodorovskiIBM deleted the bad_size_check branch November 19, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Free space calculation incorrect
2 participants