Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve resource loading performance when updating #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

atitan
Copy link

@atitan atitan commented Aug 21, 2018

The original creates a lot of N+1 queries when collection set is large.

Query everything in the first place and assign them.

@zorab47
Copy link
Owner

zorab47 commented Aug 28, 2018

Nice! Is there a maximum number of records where performance degrades?

@atitan
Copy link
Author

atitan commented Aug 30, 2018

Currently we have 300+ categories listing as a tree.
It takes about 15~20 seconds to update for every single drag in the admin panel.

I was able to cut it down to 2 seconds with this patch.

@zorab47
Copy link
Owner

zorab47 commented Sep 2, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants