Switch from Poltergeist/Phantomjs over to Selenium/Firefox headless #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should probably be merged after #79 is merged. |
Phantomjs is no longer maintained while Selenium/Firefox are well-maintained. Chrome is sometimes too good and catches developer mistakes too well, and speed is not the most important since there is not a lot of feature specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phantomjs is no longer maintained while Selenium/Firefox are well-maintained. The reason why I chose Selenium and Firefox over Chrome is that Chrome is sometimes too good and catches developer mistakes too well, and speed is not the most important since there is not a lot of feature specs.