This repository was archived by the owner on Apr 30, 2025. It is now read-only.
Event-based profiling #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for a tail-recursive 9 to never hit the RET block.
joemfb
reviewed
Nov 20, 2023
There was a problem hiding this comment.
This looks reasonable at a glance.
One difference to note: vere rolls over the trace file every 100K entries, as a workaround for the difficulty of rendering large files. This was put in place before the Perfetto trace viewer was published, so perhaps it should be revisited on the vere side ...
joemfb
approved these changes
Nov 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ashelkovnykov since this builds off the demo-debug work and in particular the cold-state matching, I'm targeting it at your demo-debug cleanup branch
This PR adds event-tracing profiling (-j in the king) to Ares.
TODO: