Skip to content

Revert #767 #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −9
Open

Revert #767 #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07ec131
Revert "Make sure that field errors are always visible (#767)"
dyve Oct 19, 2025
dc96965
Revert #767
dyve Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

## In development

- Make sure that field errors are always visible (#767, @xi).
- Add support for Python 3.14 (#774).
- Add support for Django 6.0 (#773).
- Update settings.rst (#756, @inpool).
Expand Down
4 changes: 2 additions & 2 deletions src/django_bootstrap5/templates/django_bootstrap5/field_errors.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% if field_errors %}
<div id="{{ field.auto_id }}_error" class="w-100">
<div id="{{ field.auto_id }}_error">
{% for text in field_errors %}
<div class="invalid-feedback d-block">{{ text }}</div>
<div class="invalid-feedback">{{ text }}</div>
{% endfor %}
</div>
{% endif %}
4 changes: 2 additions & 2 deletions tests/test_bootstrap_field_input_checkbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ def test_input_type_checkbox_is_invalid(self):
'<div class="form-check">'
'<input class="form-check-input is-invalid" id="id_test" name="test" required type="checkbox">'
'<label class="form-check-label" for="id_test">Test</label>'
'<div id="id_test_error" class="w-100">'
'<div class="invalid-feedback d-block">This field is required.</div>'
'<div id="id_test_error">'
'<div class="invalid-feedback">This field is required.</div>'
"</div>"
"</div>"
"</div>"
Expand Down
8 changes: 4 additions & 4 deletions tests/test_bootstrap_field_input_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ def test_input_type_text(self):
'<label class="form-label" for="id_test">Test</label>'
'<input type="text" name="test"'
' class="form-control is-invalid" placeholder="Test" required id="id_test">'
'<div id="id_test_error" class="w-100">'
'<div class="invalid-feedback d-block">This field is required.</div>'
'<div id="id_test_error">'
'<div class="invalid-feedback">This field is required.</div>'
"</div>"
"</div>"
),
Expand Down Expand Up @@ -201,8 +201,8 @@ def test_input_validation_failure(self):
'<span class="input-group-text">foo</span>'
'<input type="text" name="test" minlength="1" class="form-control'
' is-invalid" placeholder="Test" required id="id_test">'
'<div id="id_test_error" class="w-100">'
'<div class="invalid-feedback d-block">This field is required.</div>'
'<div id="id_test_error">'
'<div class="invalid-feedback">This field is required.</div>'
"</div>"
"</div>"
"</div>"
Expand Down