Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve capital after quote #31

Closed
wants to merge 6 commits into from
Closed

Conversation

retorquere
Copy link
Contributor

No description provided.

@dstillman
Copy link
Member

dstillman commented Mar 8, 2024

This seems to be preserving the capital after any quote, though? For example:

"Here is a “Test” of of the Sentence-Caser": "Here is a “test” of the sentence-caser",

1) Zotero.Utilities
       sentenceCase
         should stably perform sentence-casing:

      AssertionError: expected 'Here is a “Test” of of the sentence-c…' to equal 'Here is a “test” of the sentence-caser'
      + expected - actual

      -Here is a “Test” of of the sentence-caser
      +Here is a “test” of the sentence-caser

All we want to do is protect the character after opening quotation marks (", ', , and ). So even the test case here isn't right:

"<i>Erratum:</i> “Analyzing the Growth of InₓGa₁₋ₓN/GaN Superlattices in Self-Induced GaN Nanowires by x-Ray Diffraction”": "<i>Erratum:</i> “Analyzing the growth of InₓGa₁₋ₓN/GaN superlattices in self-induced GaN nanowires by x-ray diffraction”"

"Analyzing" is in the middle of the sentence, so it shouldn't be left capitalized.

@retorquere
Copy link
Contributor Author

Ah I see! Coming up.

@retorquere
Copy link
Contributor Author

In

“If you don’t actually care for somebody, how can you help them?”: Exploring Young People’s Core Needs in Mental Healthcare—Directions for Improving Service Provision

do you want Exploring capitalized, or not?

@dstillman
Copy link
Member

do you want Exploring capitalized, or not?

No. Zotero does that automatically for styles that require it (which implies that some don't):

https://www.zotero.org/support/kb/sentence_casing#sentence_case_and_subtitles

@retorquere
Copy link
Contributor Author

I have the change ready and pushed to my own clone but the PR isn't updating

@retorquere
Copy link
Contributor Author

I was pushing the wrong branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants