Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto trash emptying #1014

Merged
merged 9 commits into from
Oct 16, 2024
Merged

Auto trash emptying #1014

merged 9 commits into from
Oct 16, 2024

Conversation

michalrentka
Copy link
Contributor

Closes #986

mvasilak
mvasilak requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@mvasilak mvasilak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the defaults are initialized with 30 days and distant past, first time the app is launched with this, it will empty trash. I guess that is desired, and will also set a proper date for last trash emptying.

Zotero/Scenes/Master/Settings/General/Views/GeneralSettingsView.swift Outdated Show resolved Hide resolved
Zotero/Scenes/Master/Settings/General/Views/GeneralSettingsView.swift Outdated Show resolved Hide resolved
Zotero/Assets/en.lproj/Localizable.strings Outdated Show resolved Hide resolved
Zotero/Models/Defaults.swift Outdated Show resolved Hide resolved
@michalrentka michalrentka merged commit 3bdad24 into zotero:master Oct 16, 2024
1 check passed
@michalrentka michalrentka deleted the autoempty branch October 16, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvasilak mvasilak mvasilak approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto empty trash for "My Library"
2 participants
@michalrentka @mvasilak