-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html / Epub reader implementation #836
base: master
Are you sure you want to change the base?
Conversation
I've literally been stalking this repo since last November because I've been so excited for epub support in Zotero haha, so great to see this PR |
eaba0e7
to
084983a
Compare
5150c95
to
c94d639
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some first comments. More will follow.
Zotero/Controllers/Database/Requests/CreateHtmlEpubAnnotationsDbRequest.swift
Show resolved
Hide resolved
964a5a2
to
21003fd
Compare
02c032e
to
70d7572
Compare
Looking forward to the epub and html support! |
Glad to see it being implemented. :) |
@michalrentka some comments from testing ePUB attachments. General
Annotations
Rendering
Navigation
|
@michalrentka some comments from testing snapshot attachments. General
AnnotationsCreating annotations from text selection is not very accurate, and could result in:
These issues seem to stem from the inconsistency of the text selection box and the annotation being drawn, as if two separate text selections are considered in the end. Could be related to web view configuration. Check the following example: snapshots-in-ios.mov |
No description provided.