Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to download files at sync time #863

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

michalrentka
Copy link
Contributor

Closes #220

Copy link
Contributor

@mvasilak mvasilak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good so far, a couple of questions from testing.

  • Snapshots are not download as well. Is this planned for the future?
  • Sync seems to be stuck, even after all files are downloaded.

break

case .remote, .remoteMissing, .localAndChangedRemotely:
case .remote, .localAndChangedRemotely:
DDLogInfo("AttachmentDownloader: batch download remote\(location == .remoteMissing ? "ly missing" : "") file \(attachment.key)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DDLogInfo("AttachmentDownloader: batch download remote\(location == .remoteMissing ? "ly missing" : "") file \(attachment.key)")
DDLogInfo("AttachmentDownloader: batch download remote file \(attachment.key)")

@michalrentka michalrentka force-pushed the syncdownload branch 2 times, most recently from 476dd78 to ea7e8f0 Compare March 13, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Option to download files at sync time
2 participants