Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix coverity issues for v3 release #3774

Merged
merged 35 commits into from
Sep 19, 2024
Merged

fix: fix coverity issues for v3 release #3774

merged 35 commits into from
Sep 19, 2024

Conversation

Shobhajayanna
Copy link
Contributor

@Shobhajayanna Shobhajayanna commented Sep 17, 2024 •
edited
Loading

Description

Resolves the issues from Coverity scan for APIML v3.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@Shobhajayanna
fix coverity issues in v3
fb912cf 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Sep 17, 2024
@Shobhajayanna @pablocarle
Update gateway-service/src/main/java/org/zowe/apiml/gateway/conforman…
0dedeee 
…ce/OpenApiV2Validator.java

Co-authored-by: Pablo Carle <pablocarle@users.noreply.github.com>
Signed-off-by: ShobhaJayanna <36433611+Shobhajayanna@users.noreply.github.com>
@Shobhajayanna
revert the changes for AuthProvider class
941d7c0 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
update for the issue 194093
142576e 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
throw custom exception
0f95748 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 18, 2024
Shobhajayanna and others added 11 commits September 18, 2024 12:36
@Shobhajayanna
add null check
7ff593b 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
Merge branch 'v3.x.x' into reboot/coverity-fix-v3
5d7e169
@Shobhajayanna
sonar fix
fbcc9ac 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
refactor
1c186d4 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
Merge branch 'v3.x.x' into reboot/coverity-fix-v3
f7c854b
@Shobhajayanna
adding tests to increase code coverage
b34775c 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
Merge branch 'v3.x.x' into reboot/coverity-fix-v3
77ad870
@Shobhajayanna
fix IT
b1be960 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
fix IT
5011772 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
Merge branch 'v3.x.x' into reboot/coverity-fix-v3
e51e0dc
@Shobhajayanna
sonar fix
71c9dbc 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 18, 2024
@Shobhajayanna
add more test coverage
bf1ff39 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
ignoring few lines of code for sonar
13ec04c 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
add more tests
3803925 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
fix sonar
52fc2bc 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@pull-request-size pull-request-size bot added size/M and removed size/L labels Sep 18, 2024
@Shobhajayanna
refactor
e5387b1 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
add tests for sonar
fe5e7a7 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 18, 2024
@Shobhajayanna
refactor
ef6fcb9 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
refactor
0236835 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
refactor
cc99b60 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@pull-request-size pull-request-size bot added size/M and removed size/L labels Sep 19, 2024
Shobhajayanna and others added 3 commits September 19, 2024 10:37
@Shobhajayanna
fix review comments
be07af2 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
Merge branch 'v3.x.x' into reboot/coverity-fix-v3
b56bf42
@Shobhajayanna
fix review comments
30db4dd 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 19, 2024
@Shobhajayanna
fix review comments
74a0d51 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
fix review comments
b71bd30 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@Shobhajayanna
add coverage
96ddb49 
Signed-off-by: sj895092 <shobhackm9@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Shobhajayanna Shobhajayanna merged commit 982ca45 into v3.x.x Sep 19, 2024
28 checks passed
@Shobhajayanna Shobhajayanna deleted the reboot/coverity-fix-v3 branch September 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablocarle pablocarle pablocarle approved these changes

Assignees
No one assigned
Labels
Sensitive Sensitive change that requires peer review size/L
Projects
API Mediation Layer Backlog Management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shobhajayanna @pablocarle