chore: fix sonar issues #3789
Open
chore: fix sonar issues #3789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kPeriod=true&issueStatuses=OPEN%2CCONFIRMED&branch=v3.x.x&id=zowe_api-layer&open=AZG8RKZMaDaTTh7MLIqJ&tab=code Signed-off-by: Richard Salac <richard.salac@broadcom.com>
github-actions
bot
added
the
Sensitive
…kPeriod=true&issueStatuses=OPEN%2CCONFIRMED&branch=v3.x.x&id=zowe_api-layer&open=AZG8RK7RaDaTTh7MLItk Signed-off-by: Richard Salac <richard.salac@broadcom.com>
…kPeriod=true&issueStatuses=OPEN%2CCONFIRMED&branch=v3.x.x&id=zowe_api-layer&open=AZG8RKvGaDaTTh7MLIsc Signed-off-by: Richard Salac <richard.salac@broadcom.com>
…kPeriod=true&issueStatuses=OPEN%2CCONFIRMED&branch=v3.x.x&id=zowe_api-layer&open=AZG8RKyvaDaTTh7MLIsj Signed-off-by: Richard Salac <richard.salac@broadcom.com>
|
pj892031
reviewed
Sep 20, 2024
| ArrayList<String> result = new ArrayList<>(); | ||
|
|
||
| String ssoCookie = getAuthenticationCookie(passedAuthenticationToken); | ||
|
|
||
| HttpHeaders headersSSO = new HttpHeaders(); |
There was a problem hiding this comment.
We cannot remove JWT from the calls. It is necessary to obtain it from the Authentication object (security context). And in the case, JWT is not accessible there (ie. access with x509), obtain a new token.
| @@ -186,8 +145,8 @@ private List<String> fromResponseReturnFoundProblems(ResponseEntity<String> resp | |||
| result.add("Documented endpoint at " + currentEndpoint.getUrl() + " could not be located, attempting to call it through gateway gives the ZWEAM104E error"); | |||
| } | |||
|
|
|||
| if (attemptWithSSO && responseBody != null && (response.getStatusCode() == HttpStatus.FORBIDDEN || response.getStatusCode() == HttpStatus.UNAUTHORIZED)) { | |||
| result.add(method + " request to documented endpoint at " + currentEndpoint.getUrl() + " responded with status code " + response.getStatusCode().value() + ", despite being called with the SSO authorization"); | |||
There was a problem hiding this comment.
Once user is authenticated the SSO message is still valid I guess
| * @return List of problems | ||
| */ | ||
| public List<String> testEndpointsByCalling(Set<Endpoint> endpoints, String passedAuthenticationToken) { | ||
| ArrayList<String> result = new ArrayList<>(checkEndpointsNoSSO(endpoints)); |
There was a problem hiding this comment.
It maybe make sense to call each endpoint twice (with and without JWT)
| @@ -106,7 +105,7 @@ void checkValidJson() { | |||
| void whenServiceIdTooLong_thenNonconformant() { | |||
| when(messageService.createMessage(NON_CONFORMANT_KEY, "ThisWillBeRemoved")).thenReturn(NON_CONFORMANT_MESSAGE); | |||
| String testString = "qwertyuiopqwertyuiopqwertyuiopqwertyuiopqwertyuiopqwertyuiopqwertyuiop"; | |||
| result = validateAPIController.checkConformance(testString, "dummy"); | |||
There was a problem hiding this comment.
There is no test with credentials?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve sonar issues
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline