chore: expect resposne code for positive cases

integration-tests/src/test/java/org/zowe/apiml/functional/gateway/InMemoryRateLimiterFilterFactoryIntegrationTest.java

@@ -19,6 +19,7 @@
 import org.springframework.http.client.reactive.ReactorClientHttpConnector;
 import org.springframework.test.web.reactive.server.WebTestClient;
 import org.zowe.apiml.util.categories.RateLimitTest;
+import org.zowe.apiml.util.config.ConfigReader;
 import org.zowe.apiml.util.http.HttpRequestUtils;
 import reactor.netty.http.client.HttpClient;
 
@@ -31,7 +32,7 @@ public class InMemoryRateLimiterFilterFactoryIntegrationTest {
 
     private static WebTestClient client;
 
-    final int bucketCapacity = 60;
+    final int bucketCapacity = ConfigReader.environmentConfiguration().getGatewayServiceConfiguration().getBucketCapacity();
 
     @BeforeAll
     static void setUpTester() {
@@ -67,22 +68,23 @@ void testRateLimitingWhenAllowedWithCookie() {
     void testRateLimitingWhenExceeded() {
         IntStream.range(0, bucketCapacity).parallel().forEach(i -> client.get()
             .cookie("apimlAuthenticationToken", "validTokenValue")
-            .exchange());
+            .exchange().expectStatus().isOk());
+
 
         client.get()
             .cookie("apimlAuthenticationToken", "validTokenValue")
             .exchange()
             .expectStatus().isEqualTo(HttpStatus.TOO_MANY_REQUESTS)
             .expectBody()
-            .jsonPath("$.messages[0].messageReason").isEqualTo("Connections limit exceeded.");;
+            .jsonPath("$.messages[0].messageReason").isEqualTo("Connections limit exceeded.");
     }
 
     @Test
     void testRateLimiterAllowsAccessToAnotherUser() {
         // the first user requires access
         IntStream.range(0, bucketCapacity).parallel().forEach(i -> client.get()
             .cookie("apimlAuthenticationToken", "theFirstUser")
-            .exchange());
+            .exchange().expectStatus().isOk());
         //access should be denied
         client.get()
             .cookie("apimlAuthenticationToken", "theFirstUser")

integration-tests/src/test/java/org/zowe/apiml/util/config/ConfigReader.java

@@ -61,7 +61,7 @@ public static EnvironmentConfiguration environmentConfiguration() {
                         log.warn("Can't read service configuration from resource file, using default: http://localhost:10010", e);
                         Credentials credentials = new Credentials("user", "user");
                         GatewayServiceConfiguration gatewayServiceConfiguration
-                            = new GatewayServiceConfiguration("https", "localhost", null, 10010, 10017, 1, "10010", ROUTED_SERVICE);
+                            = new GatewayServiceConfiguration("https", "localhost", null, 10010, 10017, 1, "10010", ROUTED_SERVICE, 20);
                         CentralGatewayServiceConfiguration centralGatewayServiceConfiguration = new CentralGatewayServiceConfiguration("https", "localhost", 10010);
                         ZaasConfiguration zaasConfiguration = new ZaasConfiguration("https", "localhost", 10023, 1);
                         DiscoveryServiceConfiguration discoveryServiceConfiguration = new DiscoveryServiceConfiguration("https", "eureka", "password", "localhost","localhost", 10011,10021, 1);
@@ -115,6 +115,7 @@ public static EnvironmentConfiguration environmentConfiguration() {
                     configuration.getGatewayServiceConfiguration().setExternalPort(parseInt(System.getProperty("gateway.externalPort", String.valueOf(configuration.getGatewayServiceConfiguration().getExternalPort()))));
                     configuration.getGatewayServiceConfiguration().setInstances(parseInt(System.getProperty("gateway.instances", String.valueOf(configuration.getGatewayServiceConfiguration().getInstances()))));
                     configuration.getGatewayServiceConfiguration().setServicesEndpoint(System.getProperty("gateway.servicesEndpoint", configuration.getGatewayServiceConfiguration().getServicesEndpoint()));
+                    configuration.getGatewayServiceConfiguration().setBucketCapacity(parseInt(System.getProperty("gateway.bucketCapacity", String.valueOf(configuration.getGatewayServiceConfiguration().getBucketCapacity()))));
 
                     CentralGatewayServiceConfiguration config = configuration.getCentralGatewayServiceConfiguration();
                     Optional.ofNullable(config).ifPresent(c -> {

integration-tests/src/test/java/org/zowe/apiml/util/config/GatewayServiceConfiguration.java

@@ -26,4 +26,5 @@ public class GatewayServiceConfiguration implements ServiceConfiguration {
     private int instances;
     private String internalPorts;
     private String servicesEndpoint;
+    private int bucketCapacity;
 }

integration-tests/src/test/resources/environment-configuration-attls.yml

@@ -11,6 +11,7 @@ gatewayServiceConfiguration:
     externalPort: 10030
     instances: 1
     servicesEndpoint: gateway/api/v1/services
+    bucketCapacity: 20
 zaasConfiguration:
     scheme: https
     host: zaas-service

integration-tests/src/test/resources/environment-configuration-docker.yml

@@ -11,6 +11,7 @@ gatewayServiceConfiguration:
     externalPort: 10010
     instances: 1
     servicesEndpoint: gateway/api/v1/services
+    bucketCapacity: 20
 centralGatewayServiceConfiguration:
     scheme: https
     host: central-gateway-service

integration-tests/src/test/resources/environment-configuration-ha.yml

@@ -10,6 +10,7 @@ gatewayServiceConfiguration:
     externalPort: 10010
     instances: 2
     servicesEndpoint: gateway/api/v1/services
+    bucketCapacity: 20
 zaasConfiguration:
     scheme: https
     host: zaas-service

integration-tests/src/test/resources/environment-configuration.yml

@@ -11,6 +11,7 @@ gatewayServiceConfiguration:
     externalPort: 10010
     instances: 1
     servicesEndpoint: gateway/api/v1/services
+    bucketCapacity: 20
 centralGatewayServiceConfiguration:
     scheme: https
     host: localhost