-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: look for typedoc ending in .zip #4110
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these required steps.
Need help? Contact the Doc Squad in the #zowe-doc Slack channel. |
📁 The PR description is missing the file name(s) for the updated content. List all the files included in this PR so this information displays in our Zowe Docs GitHub Slack channel. If you have addressed this issue already, refresh this page in your browser to remove this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix, @traeok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
Describe your pull request here:
Recently, the typedoc was updated so that a
.zip.bundle
file is packaged alongside the other files in the Zowe release folder. However, this broke the grep check inupdateTypedoc.sh
that looks for the typedoc ZIP and it grabs the bundle instead, causingunzip
to fail on line 25 of the script. This PR updates the check so it grabs the ZIP rather than the.zip.bundle
file.List the file(s) included in this PR:
scripts/updateTypedoc.sh