Skip to content

config changes for zlux-editor to work #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wadkarsatish
Copy link
Contributor

This PR addresses the issues below.

  1. Remove unnecessary webpack module rules. As we are using '@ngtools/webpack' to build the angular contents so no need of 'ts-loader' and 'angular2-template-loader'.
  2. The same goes with a rule for loading "html" files. The compilation will be done through '@ngtools/webpack' so no need to explicitly load the html templates.
  3. desktop.ts added few more library references which is needed for plugins(zlux-editor, file manager)

Signed-off-by: Satish Wadkar <swadkar@rocketsoftware.com>
Copy link
Contributor

@sakshibobade21 sakshibobade21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes, and everything works as expected. Thanks for the PR! Approving it.

@1000TurquoisePogs 1000TurquoisePogs merged commit f9ed0b2 into zowe:v3.x/staging Feb 21, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants