-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix junit and jest-stare output in wrong folder #167
Conversation
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 74.77% 74.77%
=======================================
Files 24 24
Lines 337 337
Branches 43 44 +1
=======================================
Hits 252 252
Misses 85 85 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! 🙏
I didn't realize that the results where not passed to other reporters as expected
# Before
** jest-stare --testResultsProcessor: wrote output report to __tests__/__results__/unit/jest-stare/index.html **
# After
** jest-stare --testResultsProcessor: wrote output report to __tests__/__results__/unit/jest-stare/index.html **
** jest-stare passed results to additional processor "jest-junit" **
** jest-stare passed results to additional processor "jest-html-reporter" **
No problem 😋 I should probably mention because it confused me at first, that moving the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Timothy
What It Does
Typically the
__tests__/__results__
directory is structured like the following for unit test results:This PR fixes
jest-stare
folder being duplicated andjunit.xml
file being at wrong level:How to Test
Review Checklist
I certify that I have:
Additional Comments
Once this PR and related ones for other plug-ins are merged, the Zowe CLI Coverage workflow should start passing again 😋