Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a memory leak in getUseridByExternalInfo (v2) #511

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

ifakhrutdinov
Copy link
Contributor

Proposed changes

The PR adds a missing FREE_STRUCT31 macro invocation to the branch taken when a bad function code is passed to getUseridByExternalInfo.

This PR addresses Issue: #467

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • New and existing unit tests pass locally with my changes
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings

Testing

Regression testing of the getUseridByExternalInfo function in c/rsusermap.c is needed.

…ternalInfo

Signed-off-by: Irek Fakhrutdinov <ifakhrutdinov@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
@ifakhrutdinov ifakhrutdinov merged commit b154290 into v2.x/staging Feb 10, 2025
9 checks passed
@ifakhrutdinov ifakhrutdinov deleted the bugfix/rsusermap-leak-v2 branch February 10, 2025 19:38
@ifakhrutdinov ifakhrutdinov self-assigned this Feb 10, 2025
@ifakhrutdinov ifakhrutdinov added the bug Something isn't working label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants