Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend slh max size to avoid 0C4 ABENDs #669

Conversation

Pamazok
Copy link
Contributor

@Pamazok Pamazok commented Nov 26, 2023

Proposed changes

For some "content" the allocated SLH size (technically the number of blocks) is not enough, so ZSS thread is ABENDed with 0C4-4 like below:

SLH at 0x3FF90A50 cannot allocate above block size 16 > 0 mxbl 2 bkct 2 bksz 65535
httpserver: ABEND 0C4-04 averted when handling datasetContents

Technically we increased the number of max blocks, so we do not request a 2 times bigger buffer.
But it's enough for some cases.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

PR Checklist

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)

Testing

The bug was found by the "OMEGAMON for Storage" team and we verified that the issue solved with these changes.

Signed-off-by: Alex Agoltsov <alex.agoltsov@outlook.com>
@Pamazok Pamazok force-pushed the bugfix/fix-0c4-abend-in-update-dataset branch from 8aaa51d to 8edc2a8 Compare November 26, 2023 11:10
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was discussed on call last week and agreed to be a good change.
Thank you for the investigation and PR.

@1000TurquoisePogs 1000TurquoisePogs merged commit 5bc2894 into zowe:v2.x/staging Nov 28, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants