Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace i32 with u32 in build.rs #55

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Replace i32 with u32 in build.rs #55

merged 1 commit into from
Feb 8, 2024

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Feb 7, 2024

clippy says n and i are i32 and warns about the cast to usize

error: casting `i32` to `usize` may lose the sign of the value
  --> build.rs:32:32
   |
32 |         let mut crc = table[0][n as usize];
   |                                ^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_sign_loss

This calms down clippy about those, and a few other minor issues it raises.

@jayvdb jayvdb marked this pull request as ready for review February 7, 2024 00:21
@zowens zowens self-requested a review February 8, 2024 16:32
@zowens zowens merged commit 4bd4615 into zowens:master Feb 8, 2024
6 checks passed
@jayvdb jayvdb deleted the minor branch February 8, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants