Open
Conversation
Contributor
Author
|
I have also added GitHub action builds! |
zpl-zak
requested changes
Aug 7, 2021
Member
zpl-zak
left a comment
zpl-zak
left a comment
There was a problem hiding this comment.
FetchContent is really a nice helper I've started using in zpl-c/track, I'm glad you've introduced it in this repo! The cmake changes are really good, thank you!
As for GitHub CI, would it be possible to merge the whole build pipeline under one workflow file? I think it could greatly benefit from matrix jobs. What do you think?
Thank you again!
Contributor
Author
|
Not a problem at all, I will look into these changes as soon as I get home. |
Member
|
Hey @alextwothousand It's been a while since the last message. Is it something you are still planning on doing? |
Contributor
Author
|
Hi!
I actually did do this, and it worked fine, I just forgot to push the changes. I’m on holiday right now, and I caught a few nasty illnesses while abroad, so I doubt i’ll be able to do anything for a couple of weeks.
Sorry for the wait.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Vladyslav Hrytsenko ***@***.***>
Sent: Friday, July 29, 2022 7:00:57 AM
To: zpl-c/enet ***@***.***>
Cc: alex ***@***.***>; Mention ***@***.***>
Subject: Re: [zpl-c/enet] add CMake FetchContent support (#34)
Hey @alextwothousand<https://github.com/alextwothousand>
It's been a while since the last message. Is it something you are still planning on doing?
—
Reply to this email directly, view it on GitHub<#34 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJIECXGSIEACMGYOLJ5JJIDVWNXRTANCNFSM5BXSLXYA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@alextwothousand any news on this? |
Member
|
Hey @alextwothousand, how is it going? Any chance of getting this finished? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake, since version 3.11, introduced a feature called FetchContent. It is not very well known.
For projects that utilise CMake, FetchContent aims to add a form of package management to CMake.