Add context menu #27
Open
Add context menu #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! I definitely like the idea with the associated people! I've already started implementing a context menu (without associated people), but it's not finished yet, so I haven't pushed my current implementation. I haven't looked at your code closely, but I'm sure that both implementations can be combined. It will probably be some time before I come back to the context menu and take a closer look at your PR. First, I want to improve some core aspects of the tree builder class and clean up the code for long-term maintainability. I am sorry that it is going to take me some time to get back to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a context menu to FTV. Now, with a right-click on a person or family, a context menu appears, and allows editing the person or family. For persons, it also allows to select a person from the list of associated people and set them as active. I think this is the missing interaction that will allow navigating to any linked person in the tree.
The reason I want this is because I configured FTV to open the panel on a single click, and set the person as active on a double click. It makes it super easy to navigate in the tree, but editing requires too much interaction now :)
WDYT?