Remove the trailing comma in the timeline event box if no place name #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event box in the timeline shows a trailing comma after the event date, even when there is no event place.
In the case where an event has no place, self.ftv.get_full_place_name_from_event(event) returns "" instead of None. Of the various ways to fix this, this PR leaves the test for None intact and adds a test for "" to the else block, to allow for potential future changes to self.ftv.get_full_place_name_from_event().
I'm submitting this trivial cosmetic change as a way to learn the ins and outs of PR submission at Github. Feedback on my submission process is appreciated.
Also, I have five other PRs (so far) to submit for bug fixes and an enhancement on the assumed TODO list. All of them are for family_tree_view_timeline.py. Each PR is about a half-dozen lines or less of contiguous code. Would you like me to submit them all at once, or stagger them over time?