-
-
Notifications
You must be signed in to change notification settings - Fork 394
install: Migrate from setup.py to pyproject.toml. #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
name="zulip", | ||
version=version(), | ||
description="Bindings for the Zulip message API", | ||
long_description=long_description, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is superseded by readme = "README.md"
in the pyproject.toml version. I checked the resulting METADATA file in the package info, and it showed the entire README.md in it.
Source = "https://github.com/zulip/python-zulip-api/" | ||
Documentation = "https://zulip.com/api" | ||
|
||
[project.scripts] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the scripts all exist in the installed virtualenv bin directory.
zulip-api = "zulip.cli:cli" | ||
|
||
[tool.hatch.version] | ||
path = "zulip/__init__.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version is correctly extracted as 0.9.0
.
Did you consider uv instead of Setuptools or Hatch? You only migrated zulip, but we publish zulip-bots and zulip-botserver in sync with zulip, so we should migrate all three packages at once, perhaps using uv workspaces (it looks like Hatch is still missing an equivalent feature: pypa/hatch#233). |
I wasn't aware of |
support recursive file includes.
Fixes: N/A
How did you test this PR?
pytest tests
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: