Skip to content

Enable fullscreen video on macOS #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable fullscreen video on macOS #1456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions app/renderer/js/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,20 +961,22 @@ export class ServerManagerView {
permissionCallbackId: number,
) => {
const grant =
webContentsId === null
? origin === "null" && permission === "notifications"
: (
await Promise.all(
this.tabs.map(async (tab) => {
if (!(tab instanceof ServerTab)) return false;
const webview = await tab.webview;
return (
webview.webContentsId === webContentsId &&
webview.properties.hasPermission?.(origin, permission)
);
}),
)
).some(Boolean);
permission === "fullscreen"
? true
: webContentsId === null
? origin === "null" && permission === "notifications"
: (
await Promise.all(
this.tabs.map(async (tab) => {
if (!(tab instanceof ServerTab)) return false;
const webview = await tab.webview;
return (
webview.webContentsId === webContentsId &&
webview.properties.hasPermission?.(origin, permission)
);
}),
)
).some(Boolean);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't like how hasPermission works currently. Changes should be made in hasPermission instead and not here.

console.log(
grant ? "Granted" : "Denied",
"permissions request for",
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.