You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(chris edit: added screenshot and "Related issues" and "Implementation" sections)
When a channel message appears in a multi-channel narrow (like the combined feed), the recipient header has the channel name as well as topic.
Expected: Tapping anywhere in the channel part of the header (highlighted below) should lead to the channel narrow:
Actual: Tapping directly on the text of the channel name leads to the channel narrow. But tapping slightly above or below leads instead to the topic narrow.
Related issues
This will also be relevant for the channel action sheet, which will be offered on long-press in this area:
I would like to contribute to this issue,kindly assign me
The problem is that the entire recipient header (including the channel area) is wrapped in a single GestureDetector that navigates to the topic narrow. We need to properly separate the gesture areas for the channel and topic sections.
Set gesture detecter behavior of streamWidget to HitTestBehavior.opaque
to handle taps in empty space around the header.
Also added a test that checks if tapping empty space in channel header
area correctly navigates to the channel feed.
Fixeszulip#1179.
(chris edit: added screenshot and "Related issues" and "Implementation" sections)
When a channel message appears in a multi-channel narrow (like the combined feed), the recipient header has the channel name as well as topic.
Expected: Tapping anywhere in the channel part of the header (highlighted below) should lead to the channel narrow:
Actual: Tapping directly on the text of the channel name leads to the channel narrow. But tapping slightly above or below leads instead to the topic narrow.
Related issues
This will also be relevant for the channel action sheet, which will be offered on long-press in this area:
Implementation
I believe the bug can be fixed by adding a line to the relevant
GestureDetector
:We also need a widget test for the fix; we won't merge a PR without this. The test should pass after the fix and fail before the fix.
The text was updated successfully, but these errors were encountered: