combined feed: Fix channel header tap behaviour in combined feed #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E-m-i-n-e-n-c-e
force-pushed
the
1368
branch
2 times, most recently
from
41f52a0 to
431f1cd
Compare
Set gesture detecter behavior of streamWidget to HitTestBehavior.opaque to handle taps in empty space around the header. Also added a test that checks if tapping empty space in channel header area correctly navigates to the channel feed. Fixes zulip#1368.
E-m-i-n-e-n-c-e
force-pushed
the
1368
branch
from
431f1cd to
81c835a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the channel header navigation in the combined feed view
Changes
GestureDetectorinStreamMessageRecipientHeaderto useHitTestBehavior.opaqueRelated Issues:
Closes #1179
I have verified that the test fails before the changes and the test passes after the changes