Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightbox: Prevent hero animation between message lists #1348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lightbox: Prevent hero animation between message lists #1348

wants to merge 1 commit into from

Conversation

lakshya1goel
Copy link
Contributor

Fixes: #930

Videos

Before

WhatsApp.Video.2025-02-12.at.5.18.39.PM.mp4

After

WhatsApp.Video.2025-02-12.at.5.18.35.PM.mp4

@lakshya1goel lakshya1goel marked this pull request as draft February 12, 2025 13:36
@lakshya1goel lakshya1goel marked this pull request as ready for review February 15, 2025 16:01
@lakshya1goel lakshya1goel changed the title msglist: Prevent hero animation between message lists lightbox: Prevent hero animation between message lists Feb 15, 2025
@lakshya1goel lakshya1goel mentioned this pull request Feb 15, 2025
Open
@gnprice
Copy link
Member

gnprice commented Feb 15, 2025

Thanks! Chat thread here:
https://chat.zulip.org/#narrow/channel/516-mobile-dev-help/topic/Hero.20animation/near/2092791
with comments particularly on how to write a good test for this fix.

@PIG208 PIG208 self-assigned this Feb 18, 2025
@PIG208 PIG208 added the maintainer review PR ready for review by Zulip maintainers label Feb 18, 2025
@PIG208 PIG208 self-requested a review February 21, 2025 21:55
@lakshya1goel
Copy link
Contributor Author

lakshya1goel commented Feb 22, 2025 •
edited
Loading

Hi @PIG208, PR is ready for a review now, PTAL, Thanks!
Related CZO Discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PIG208 PIG208 Awaiting requested review from PIG208

Assignees

@PIG208 PIG208

Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hero animation for images should run only to/from lightbox, not between message lists
3 participants
@lakshya1goel @gnprice @PIG208