general chat #2: support sending to empty topic from channel narrow, hide resolve/unresolve conditionally #1364
+401
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixuan James Li <zixuan@zulip.com>
instead of inferring it from a TopicName Signed-off-by: Zixuan James Li <zixuan@zulip.com>
Signed-off-by: Zixuan James Li <zixuan@zulip.com>
Signed-off-by: Zixuan James Li <zixuan@zulip.com>
This helps imply why we don't have the check when displayName is null Signed-off-by: Zixuan James Li <zixuan@zulip.com>
Signed-off-by: Zixuan James Li <zixuan@zulip.com>
Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208
force-pushed
the
pr-general-chat-2
branch
from
5382b42 to
d2a820f
Compare
Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208
force-pushed
the
pr-general-chat-2
branch
from
d2a820f to
61d5a9c
Compare
PIG208
changed the title
A test is skipped because the server does not send empty topics to the client without "empty_topic_name" client capability. Signed-off-by: Zixuan James Li <zixuan@zulip.com>
This behavior is designed to replace how sending to an empty topic is effectively sending to "(no topic)". The key difference being that the `TopicName.apiValue` is actually empty, instead of being converted to "(no topic)" with `_computeTextNormalized`. Signed-off-by: Zixuan James Li <zixuan@zulip.com>
Previously, "Message #stream > general chat" was the hint text for content input as long as the topic input is empty and topics are not mandatory. Showing the default topic does not help create incentive for the user to pick a topic first. So only show it when they intend to leave the topic empty. See discussion: https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/general.20chat.20design.20.23F1297/near/2088870 Signed-off-by: Zixuan James Li <zixuan@zulip.com>
Signed-off-by: Zixuan James Li <zixuan@zulip.com>
Signed-off-by: Zixuan James Li <zixuan@zulip.com>
Look for `allow_empty_topic_name` and `empty_topic_name` under "Feature level 334" in the API Changelog to verify the affected routes: https://zulip.com/api/changelog Fixes: zulip#1250 Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208
force-pushed
the
pr-general-chat-2
branch
from
61d5a9c to
5bfdaaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1297, this PR focuses on part of the general chat feature, with some final "do not merge" commits to make it testable.
This includes the following commits:
The remaining commits should be reviewed in #1297, but neither PR blocks each other, as they each focuses on a specific part of the feature.
Screenshots