Update AGP to 7.2.2; run yarn upgrade
#5818
Conversation
|
Thanks for taking care of this! All LGTM except it looks like it needs a |
chrisbobbe
force-pushed
the
pr-yarn-upgrade-2024-01-23
branch
from
a582a3b to
c0c9054
Compare
|
Done; thanks! Revision pushed. |
There was a problem hiding this comment.
Thanks! There's now a later failure in CI:
Run tools/verify-webview-js
generatedEs3.js is not updated with current js file.
Error: Process completed with exit code 1.
(If we weren't in the process of abandoning this codebase, we should probably fold that check into tools/test like the rest of them.)
Also a comment below just about the patch message on one of the new TsFlower patches.
| Subject: [tsflower] rnsac: Fix `React.JSX.Element`s that didn't get rewritten | ||
|
|
||
| I think this is supposed to be taken care of by TsFlower...see | ||
| prepGlobalJsxRewrites in rewrite/react.ts. Anyway, just do it | ||
| manually, using the type that it looks like TsFlower should have | ||
| used (`JSX$Element` in subst/react.js.flow). |
There was a problem hiding this comment.
Hmm fun.
I agree this looks like the right answer. Rereading that code, what prepGlobalJsxRewrites says is that JSX.Element (with the global JSX namespace, not imported from anywhere) should get rewritten to that. So it seems likely that React.JSX.Element is intended to mean the same thing as JSX.Element.
So that function is a good place to look for a hint about what this type from React probably means. But I think the fix in principle is just another item in the list of rewrites.
There was a problem hiding this comment.
Hmm, OK. I've opened up the TsFlower code and I plan to make a PR doing that.
chrisbobbe
force-pushed
the
pr-yarn-upgrade-2024-01-23
branch
from
c0c9054 to
7f437f3
Compare
|
Thanks for the review! Revision pushed, incorporating the improvement in the TsFlower tool; thanks for your help with that. |
|
Ah and I see I still need to run |
…write See gnprice/tsflower#2 . This rewrite will get used in a `yarn upgrade`, coming soon.
Release notes here: https://developer.android.com/build/releases/past-releases/agp-7-2-0-release-notes Done because the upcoming `yarn upgrade` would otherwise cause a build failure with a message that looks similar to one that reportedly was resolved by upgrading to AGP 7.2.0: https://stackoverflow.com/a/74808149 and it turns out that our error is also resolved by upgrading. In our case we upgraded to the latest 7.2.x, which right now is 7.2.2. Our error message had this: gradle Error: Can't determine type for tag '<macro name="m3_comp_assist_chip_container_shape">?attr/shapeAppearanceCornerSmall</macro>'
Tested on Android (office device) and iOS (my iPhone). See the previous commit about some preparation that was needed; we upgraded the AGP.
chrisbobbe
force-pushed
the
pr-yarn-upgrade-2024-01-23
branch
from
7f437f3 to
1222bc9
Compare
|
OK, done; revision pushed. |
|
Thanks! Looks good; merging. |
No description provided.