Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade @sentry/react-native to fix iOS build failure with Xcode 16 #5916

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

chrisbobbe
Copy link
Contributor

@chrisbobbe chrisbobbe commented Feb 18, 2025

See issue:
getsentry/sentry-react-native#3883

Reportedly, the first working version is 5.24.1. So, use ~5.24.1 for the range, pulling in 5.24.3.

With ^5.9.2, I was getting 5.36.0, which came with an Android build failure that looked like #5345.

…e 16

See issue:
  getsentry/sentry-react-native#3883

Reportedly, the first working version is 5.24.1. So, use `~5.24.1`
for the range, pulling in 5.24.3.

With ^5.9.2, I was getting 5.36.0, which came with an Android build
failure that looked like zulip#5345.
@chrisbobbe chrisbobbe force-pushed the pr-upgrade-sentry-react-native branch from 215c9f2 to 1724b91 Compare February 18, 2025 22:35
@chrisbobbe
Copy link
Contributor Author

Here's that Android build failure (output of tools/test native --all-files):
android-test-output.txt

@gnprice
Copy link
Member

gnprice commented Feb 18, 2025

Thanks!

These changes look good — please go ahead and merge once CI passes.

@chrisbobbe chrisbobbe merged commit 4d9d46d into zulip:main Feb 18, 2025
1 check passed
@chrisbobbe chrisbobbe deleted the pr-upgrade-sentry-react-native branch February 18, 2025 23:17
@chrisbobbe
Copy link
Contributor Author

Thanks! Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants