Update README.md and add overlay option #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the developer decide if he wants to show to overlay or not
Add option "overlay"
1. When you set "transition_in" to true, the handle will smoothly "go" to the point you set in "default_offset_pct". 2. When the plugin is ready it calls to "init.twentytwenty" so you can listen to this event. 3. You can call now to "goTo" function to with the percent you want the handle will go.
Contributor
|
Hey @moshfeu #72 introduced the same functionality for suppressing the overlay. As for min_offset and the events and methods for programatic control that is interesting and I would like to see those introduced. This branch needs a bit of love before it can be merged. If you are still interested and want to touch up the branch let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.md
Plugin code
overlay.min_offset