fix: reduce ToolServer contention during tool lookup and execution#1607
Merged
gold-silver-copper merged 15 commits into0xPlaygrounds:mainfrom Apr 7, 2026
Merged
Conversation
…d additional tests for concurrency
… into Arc internally
…roved performance
… reduce unnecessary Arc wrapping
… into Arc internally fix: remove unnecessary Arc wrapping in dynamic_context calls for improved performance fix: simplify dynamic_context parameter type to improve usability and reduce unnecessary Arc wrapping
…isSerge/rig into fix-concurrent-exec-block-in-toolserver
…isSerge/rig into fix-concurrent-exec-block-in-toolserver
…isSerge/rig into fix-concurrent-exec-block-in-toolserver
Contributor
|
Awesome PR, thanks @isSerge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1573
ToolServermpsc/oneshotmessage loop with a sharedToolServerHandle(Arc<RwLock<...>>)implementation.ToolSetinternals to store tools behindArcso tool handles can be cloned under a short read lock before executing.SleeperToolwithBarrierToolto avoid artificial sleeping in existing tests