Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php cs fixer #60

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

neo-garaix
Copy link
Collaborator

@neo-garaix neo-garaix commented Jan 27, 2025

Adding PHP CS Fixer to the project

  • No we can test our PHP quality with PHP CS Fixer

PHP CS Fixer is using a configuration file called .php-cs-fixer.dist.php.

Two commands are added through composer :

  • cs-check : Check the PHP quality without fixing it.
  • cs-fix : Fix the PHP.

Commit a534409 is here to fix this issue from #61

@Gustry Gustry mentioned this pull request Jan 27, 2025
@neo-garaix neo-garaix mentioned this pull request Jan 27, 2025
@Gustry Gustry mentioned this pull request Jan 27, 2025
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Gustry Gustry requested a review from nworr January 29, 2025 09:36
Copy link
Contributor

@nworr nworr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, nice usage of composer script :) thanks

'tests/',
])
;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment to inform CS Rules should match with LWC
https://github.com/3liz/lizmap-web-client/blob/master/.php-cs-fixer.dist.php ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants