-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add php cs fixer #60
base: master
Are you sure you want to change the base?
Add php cs fixer #60
Conversation
7ba8aee
to
0e6b089
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good, nice usage of composer script :) thanks
'tests/', | ||
]) | ||
; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment to inform CS Rules should match with LWC
https://github.com/3liz/lizmap-web-client/blob/master/.php-cs-fixer.dist.php ?
Adding PHP CS Fixer to the project
PHP CS Fixer is using a configuration file called
.php-cs-fixer.dist.php
.Two commands are added through composer :
cs-check
: Check the PHP quality without fixing it.cs-fix
: Fix the PHP.Commit a534409 is here to fix this issue from #61