Add PHP Stan #61
Merged
Add PHP Stan #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
nboisteault
approved these changes
Jan 31, 2025
Gustry
approved these changes
Jan 31, 2025
|
I'm not sure why this PR has been closed by "me", while I was merging #60... |
neo-garaix
force-pushed
the
add-php-stan
branch
from
c6982b8 to
bf49d31
Compare
Gustry
approved these changes
Jan 31, 2025
| @@ -29,8 +28,8 @@ public function onmainviewGetMaps($event) | |||
| // Reproject extent in ini file from EPSG:4326 to EPSG:3857. | |||
| if (class_exists('Proj4php')) { // lizmap 3.6 | |||
| $proj4 = new Proj4php(); | |||
| $sourceProj = new Proj4phpProj('EPSG:4326', $proj4); | |||
| $destProj = new Proj4phpProj('EPSG:3857', $proj4); | |||
| $sourceProj = new Proj4phpProj('EPSG:4326', $proj4); /* @phpstan-ignore class.notFound */ // Used for older version of lizmap | |||
There was a problem hiding this comment.
According to https://github.com/3liz/lizmap-mapbuilder-module/blob/master/mapBuilder/module.xml#L13
and as this PR is targeting only the master branch, so minimum LWC 3.8, this code can be removed now.
We can do it after.
There was a problem hiding this comment.
I can do a little new PR ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding PHP Stan to the project
PHP Stan is using a configuration file called
phpstan.neon.A command is added through composer :
phpstan: Check the PHP code quality.This PR will be rebased on #60. I created it in order to see the addition of PHPStan above changes from PHP CS Fixer