-
Notifications
You must be signed in to change notification settings - Fork 2
Merge/pr 158 local #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Merge/pr 158 local #180
Conversation
73junito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds content validation infrastructure for AI-generated learning materials, implementing a "stub" vs "humanized" content workflow. The PR introduces validation scripts, test coverage, CI workflows, and updates all course manifests to include a contentStatus field.
Changes:
- Adds content validation scripts and CI workflows to block stub content from being merged
- Updates 20+ course manifests to include
contentStatusfield (mostly "stub", one "humanized") - Adds comprehensive test coverage for the orchestration pipeline and removes duplicate code from Storybook files
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/orchestrate_content.py | New orchestration script for AI content generation (contains critical structural bugs) |
| tests/test_orchestrate_content.py | Test suite for orchestration functionality |
| scripts/validate_no_stubs.py | Validator script to detect stub content in manifests and markdown |
| scripts/bulk_set_content_status.py | Bulk update utility for setting contentStatus across manifests |
| .github/workflows/block-stubs.yml | CI workflow to prevent merging PRs with stub content |
| .github/workflows/orchestrate-test.yml | CI workflow for testing orchestration (references non-existent fixture) |
| docs/ai/ai-toolkit-guidance.md | Advisory guidance for AI-assisted content authoring (contains duplicate content) |
| docs/benchmarks/ollama-client-benchmark.md | Benchmark comparison of Python/Node/Rust Ollama clients |
| content/courses/*/modules.json | Updates to 20+ course manifests adding contentStatus field |
| README.md | Updates with content standards and benchmark references (broken markdown) |
| CONTRIBUTING.md | New contributor guidance file |
| .vscode/settings.json | New VS Code workspace settings (hardcoded Windows paths) |
| scripts/generate_modules_manifest.ps1 | Updated to add contentStatus field to generated manifests |
| scripts/regenerate_pnpm_lock.ps1 | New PowerShell utility for pnpm lockfile regeneration |
| packages/ui/src/components/*/stories.tsx | Removes duplicate code from Storybook files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
73junito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 36 out of 36 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 36 out of 36 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5e78bf2 to
75073b7
Compare
|
@copilot open a new pull request to apply changes based on the comments in this thread |
73junito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viewed
Co-authored-by: 73junito <86015877+73junito@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 36 out of 36 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…8-4409-b0cb-c2de0225020e Fix documentation duplication, CLI argument parsing, and workflow artifacts
73junito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viewed
…ture Co-authored-by: 73junito <86015877+73junito@users.noreply.github.com>
Co-authored-by: 73junito <86015877+73junito@users.noreply.github.com>
Co-authored-by: 73junito <86015877+73junito@users.noreply.github.com>
…8-4190-957d-deb987d34a81 Strengthen test validation for generated field structure in orchestrate_content tests
…e-4b0d-9f8e-27244d8db1ea Fix Ollama streaming response parser to handle newline-delimited JSON
…c-4a5c-833e-3f3275588d9e Fix Ollama API response parsing to use correct "response" field
Summary
Describe the change and why it is needed.
Checklist
Testing
Describe how the change was tested locally and CI steps.
Related