Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 16, 2026

Summary

  • What: Fix scripts/regenerate_pnpm_lock.ps1 to use proper PowerShell cmdlets and remove broken validation reference.
  • Why: Write-Host should not be used for informational output in scripts meant for programmatic use; referenced validation script check_pnpm_lock_yaml.py does not exist.

Changes

  • Replace all Write-Host calls with Write-Output (lines 1-9)
  • Remove reference to non-existent scripts/check_pnpm_lock_yaml.py
  • Fix quote escaping in git commit example (use single quotes)
# Before
Write-Host "Done. To validate the lockfile run:"
Write-Host "  python scripts/check_pnpm_lock_yaml.py pnpm-lock.yaml"

# After
Write-Output "Done. Commit the changes with:"
Write-Output "  git add pnpm-lock.yaml && git commit -m 'chore: regenerate pnpm-lock.yaml'"

Migration steps

N/A - direct fix to existing script

Testing

  • Manual: Verified PowerShell syntax and Write-Output usage
  • Automated: CodeQL scan passed with no alerts

Rollback plan

Single-file change; revert commit if issues arise.

Checklist

  • Write-Host replaced with Write-Output
  • Non-existent script reference removed
  • Quote escaping corrected
  • CodeQL scan passed

Reviewers


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 16, 2026 01:53
Co-authored-by: 73junito <86015877+73junito@users.noreply.github.com>
Co-authored-by: 73junito <86015877+73junito@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on PR #158 for local merge adjustments Fix PowerShell script: use Write-Output and remove non-existent script reference Jan 16, 2026
Copilot AI requested a review from 73junito January 16, 2026 01:57
Copy link
Owner

@73junito 73junito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viewed

@73junito 73junito marked this pull request as ready for review January 16, 2026 09:25
Copilot AI review requested due to automatic review settings January 16, 2026 09:25
@73junito 73junito merged commit a6ab23d into merge/pr-158-local Jan 16, 2026
4 of 7 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a PowerShell script by replacing inappropriate Write-Host calls with Write-Output and removing a reference to a non-existent validation script.

Changes:

  • Replaced Write-Host with Write-Output for proper PowerShell output handling
  • Removed broken reference to non-existent check_pnpm_lock_yaml.py script
  • Simplified output instructions with corrected quote usage

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants