tests passing. functions descriptions/tests could be more clear. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazEfron
reviewed
Jul 12, 2023
| } | ||
| // - `size` | ||
| size(){ | ||
| let curr = this.head |
There was a problem hiding this comment.
Can you think of a way to have this function run in O(1) instead of O(n)?
RazEfron
reviewed
Jul 12, 2023
| } | ||
| // - `containsDuplicates` check for duplicates - return true if contains duplicates, false if not | ||
| containsDuplicates(){ | ||
| let curr = this.head |
There was a problem hiding this comment.
Using a set you could compare the length of the set to the length of the linked list for shorter, cleaner code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term key is used several times in the test and readme but it was not clear if the key was the data stored in the node, or if it was the index of a node.