-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests passing. functions descriptions/tests could be more clear. #11
Open
felizj17
wants to merge
1
commit into
9-4-pursuit:main
Choose a base branch
from
felizj17:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,135 @@ | ||
const { nums, words } = require("./data/data.js"); | ||
|
||
|
||
class Node { | ||
constructor(data){ | ||
this.data = data | ||
this.next = null | ||
} | ||
} | ||
|
||
class LinkedList{ | ||
constructor(head = null){ | ||
this.head = head | ||
} | ||
// - `insert` | ||
insert(val){ | ||
const newNode = new Node(val) | ||
const curr = this.head | ||
this.head = newNode | ||
newNode.next = curr | ||
} | ||
// - `size` | ||
size(){ | ||
let curr = this.head | ||
let count = 0 | ||
while(curr){ | ||
count++ | ||
curr = curr.next | ||
} | ||
return count | ||
} | ||
// - `delete` by key | ||
|
||
//not sure if key is value of data or the index in the list. Wish it was more discriptive/clear | ||
delete(key){ | ||
if(!key){ | ||
this.head = this.head.next | ||
}else{ | ||
let c = 1 | ||
let prev = this.head | ||
let curr = this.head.next | ||
let next | ||
while(c <= key){ | ||
if(c === key){ | ||
prev.next = curr.next | ||
} | ||
c++ | ||
next = curr.next | ||
prev = curr | ||
curr = next | ||
} | ||
} | ||
} | ||
// - `getFirst` element | ||
getFirst(){ | ||
return this.head | ||
} | ||
// - `getLast` element | ||
getLast(){ | ||
let curr = this.head | ||
while(curr.next){ | ||
curr = curr.next | ||
} | ||
return curr | ||
} | ||
// - `search` an element by key and return data const nums = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 0]; | ||
search(key){ | ||
let curr = this.head | ||
while(curr){ | ||
if(curr.data === key){ | ||
return curr | ||
} | ||
curr=curr.next | ||
} | ||
} | ||
// - `getKth` retrieve kth element | ||
getKth(key){ | ||
let curr = this.head | ||
let c = 1 | ||
while(curr){ | ||
if(c === key){ | ||
return curr | ||
} | ||
curr=curr.next | ||
c++ | ||
} | ||
} | ||
// - `getKthToLast` retrieve kth from last element | ||
getKthToLast(k){ | ||
let index = this.size() - k | ||
let curr = this.head | ||
while(curr){ | ||
if(index==1){ | ||
return curr | ||
} | ||
curr = curr.next | ||
index-- | ||
} | ||
} | ||
// - `isEmpty` check if list is empty | ||
isEmpty(){ | ||
return this.head === null | ||
} | ||
// - `clear` the linked list | ||
clear(){ | ||
this.head = null | ||
} | ||
// - `toArray`convert data from linked list to an array | ||
toArray(){ | ||
let curr = this.head | ||
const arr = [] | ||
while(curr){ | ||
arr.push(curr.data) | ||
curr = curr.next | ||
} | ||
return arr | ||
} | ||
// - `containsDuplicates` check for duplicates - return true if contains duplicates, false if not | ||
containsDuplicates(){ | ||
let curr = this.head | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using a set you could compare the length of the set to the length of the linked list for shorter, cleaner code |
||
let set = new Set() | ||
while(curr){ | ||
if(!set.has(curr.data)){ | ||
set.add(curr.data) | ||
curr = curr.next | ||
}else{ | ||
return true | ||
} | ||
} | ||
return false | ||
} | ||
} | ||
module.exports = { | ||
Node, | ||
LinkedList, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you think of a way to have this function run in O(1) instead of O(n)?