Decouple printing logs to stdout from tensorboard #1376
+18
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 7bc0f48 introduced a config to disable tensorboard. However, it unintentionally disable printing to stdout as well. This CL separates the logic that prints logs from the logic the writes to tensorboard.
Test:
Check that enable_tensorboard=False and enable_tensorboard=True lead to the same logs on stdout.
Before submitting this PR, please make sure (put X in square brackets):