Move metric logging outside enable_tensorboard flag#1381
Closed
SurbhiJainUSC wants to merge 1 commit intomainfrom
Closed
Move metric logging outside enable_tensorboard flag#1381SurbhiJainUSC wants to merge 1 commit intomainfrom
SurbhiJainUSC wants to merge 1 commit intomainfrom
Conversation
bvandermoon
reviewed
Mar 12, 2025
Collaborator
bvandermoon
left a comment
There was a problem hiding this comment.
Looks like this is a duplicate of #1376
khatwanimohit
approved these changes
Mar 12, 2025
4 tasks
Collaborator
Author
Cool, I will close this PR then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves MaxText step/metrics log statements outside of a conditional if block. Previously, these logs were only printed when
enable_tensorboardconfiguration was set to True Ref. This change ensures that these logs are always displayed, regardless of the configuration setting.FIXES: b/401058159
Tests
MaxText step logs are visible with
enable_tensorboard=FalseChecklist
Before submitting this PR, please make sure (put X in square brackets):