Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move metric logging outside enable_tensorboard flag #1381

Closed
wants to merge 1 commit into from
Closed

Move metric logging outside enable_tensorboard flag #1381

wants to merge 1 commit into from

Conversation

SurbhiJainUSC
Copy link
Collaborator

Description

This PR moves MaxText step/metrics log statements outside of a conditional if block. Previously, these logs were only printed when enable_tensorboard configuration was set to True Ref. This change ensures that these logs are always displayed, regardless of the configuration setting.

FIXES: b/401058159

Tests

MaxText step logs are visible with enable_tensorboard=False

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

bvandermoon
bvandermoon reviewed Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is a duplicate of #1376

@bvandermoon bvandermoon mentioned this pull request Mar 12, 2025
Open
4 tasks
@SurbhiJainUSC
Copy link
Collaborator Author

Looks like this is a duplicate of #1376

Cool, I will close this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvandermoon bvandermoon bvandermoon left review comments

@khatwanimohit khatwanimohit khatwanimohit approved these changes

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner

@rni418 rni418 Awaiting requested review from rni418 rni418 is a code owner

@gagika gagika Awaiting requested review from gagika gagika is a code owner

@shralex shralex Awaiting requested review from shralex shralex is a code owner

@yangyuwei yangyuwei Awaiting requested review from yangyuwei yangyuwei is a code owner

@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo is a code owner

@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner

Assignees

@RoshaniN RoshaniN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SurbhiJainUSC @bvandermoon @khatwanimohit @RoshaniN