Skip to content

Move metric logging outside enable_tensorboard flag#1381

Closed
SurbhiJainUSC wants to merge 1 commit intomainfrom
maxtext_logging
Closed

Move metric logging outside enable_tensorboard flag#1381
SurbhiJainUSC wants to merge 1 commit intomainfrom
maxtext_logging

Conversation

@SurbhiJainUSC
Copy link
Collaborator

Description

This PR moves MaxText step/metrics log statements outside of a conditional if block. Previously, these logs were only printed when enable_tensorboard configuration was set to True Ref. This change ensures that these logs are always displayed, regardless of the configuration setting.

FIXES: b/401058159

Tests

MaxText step logs are visible with enable_tensorboard=False

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is a duplicate of #1376

@SurbhiJainUSC
Copy link
Collaborator Author

Looks like this is a duplicate of #1376

Cool, I will close this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants