Separate out the ServiceClient #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently still includes the Sparkplug Node implementation, which I'm not sure should be in here at all.
Accept a new `browser` config option to the ServiceClient. This will cause MQTT URLs to be rewritten to websocket URLs.
We have real fetch on a browser.
Dynamic import/export in JS is a bit of a pain.
Node recommends to use these but in fact they just inhibit webpacking.
For now we will have code relying on this. Ideally they'd want to be removed, or moved into their own packages.
This includes a lot of metrics to support command escalation over MQTT. These are still used by the services to generate their Sparkplug packets but they were always a bit of a hack. Either they can stay in utilities as compatibility until they are replaced or they can go out to a separate package.
Node v20 provides globalThis.fetch, but it doesn't cache, so we still need to replace it with got-fetch. Key off the browser key provided to the ServiceClient instead.
amrc-benmorrow
force-pushed
the
feature/bm-initial
branch
from
9a3f808 to
681a2d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull the ServiceClient code out from the rest of @amrc-factoryplus/utilities.
This still includes more code than I wanted it to, because it's difficult to separate out the dependencies. But this package is now webpackable.